Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Delta flush background #7088

Closed
wants to merge 2 commits into from
Closed

[WIP] Delta flush background #7088

wants to merge 2 commits into from

Conversation

hehechen
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@hehechen
background delta flush
dbfec4a 
Signed-off-by: hehechen <awd123456sss@gmail.com>
@hehechen
fix lock
2f873bf 
Signed-off-by: hehechen <awd123456sss@gmail.com>
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Mar 16, 2023
@ti-chi-bot
Copy link
Member

[FORMAT CHECKER NOTIFICATION]

Notice: To remove the do-not-merge/needs-linked-issue label, please provide the linked issue number on one line in the PR body, for example: Issue Number: close #123 or Issue Number: ref #456.

📖 For more info, you can check the "Contribute Code" section in the development guide.

@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 16, 2023
@ti-chi-bot
Copy link
Member

@hehechen: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

CalvinNeo
CalvinNeo reviewed May 29, 2023
View reviewed changes
dbms/src/Storages/Transaction/KVStore.cpp
for (const auto & region : region_copmact_indexes)
{
auto region_rowkey_range = std::get<2>(region.second);
if (rowkey_range.getStart() <= region_rowkey_range.getStart() && region_rowkey_range.getEnd() < rowkey_range.getEnd())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why < here?

CalvinNeo
CalvinNeo reviewed May 29, 2023
View reviewed changes
dbms/src/Storages/Transaction/KVStore.cpp
persistRegion(*overlapped_region.second, region_task_lock, "triggerCompactLog");
}
}
storage->flushCache(tmt.getContext(), rowkey_range);
Copy link
Member

@CalvinNeo CalvinNeo May 29, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why flushCache here before the previous loop?

CalvinNeo
CalvinNeo reviewed May 29, 2023
View reviewed changes
dbms/src/Storages/Transaction/KVStore.cpp
continue;
}
LOG_DEBUG(log, "flush extra segment of region {}, region range:[{},{}], flushed segment range:[{},{}]", region.first, region_rowkey_range.getStart().toDebugString(), region_rowkey_range.getEnd().toDebugString(), rowkey_range.getStart().toDebugString(), rowkey_range.getEnd().toDebugString());
storage->flushCache(tmt.getContext(), std::get<2>(region.second));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The flushCache is not protected by region task lock.

CalvinNeo
CalvinNeo reviewed May 29, 2023
View reviewed changes
dbms/src/Storages/Transaction/KVStore.cpp
@@ -98,6 +100,7 @@ RegionPtr KVStore::getRegion(RegionID region_id) const
return it->second;
return nullptr;
}
// TODO: may get regions not in segment?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What will happen if we also flush data from those obsolete regions?

@CalvinNeo CalvinNeo mentioned this pull request May 30, 2023
Closed
12 tasks
@CalvinNeo CalvinNeo mentioned this pull request Jul 6, 2023
Open
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CalvinNeo CalvinNeo CalvinNeo left review comments

Assignees
No one assigned
Labels
do-not-merge/needs-linked-issue do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hehechen @ti-chi-bot @CalvinNeo @JaySon-Huang