Passive flush with gap between current applied index and last flushed index #7899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hehechen <awd123456sss@gmail.com>
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
This reverts commit 5686b5c.
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
|
/run-build-release comment=true |
|
download tiflash binary(linux amd64) at http://fileserver.pingcap.net/download/builds/pingcap/test/tiflash/704959fe2fb5a33280a636d6b885ced7bad3b5a4/centos7/tiflash-linux-amd64.tar.gz |
…h_bg_without_tikv
|
/rebuild |
|
/run-all-tests |
CalvinNeo
force-pushed
the
calvin_delta_flush_bg_without_tikv
branch
from
4d249a1
to
d1743a6
Compare
|
/run-all-tests |
|
/run-all-tests |
ti-chi-bot
bot
added
release-note
|
/unhold |
ti-chi-bot
bot
removed
the
do-not-merge/hold
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
hongyunyan
approved these changes
Aug 16, 2023
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hongyunyan, JinheLin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
|
@JaySon-Huang Is there any other issue what we need to address? I want to have this PR merged now |
…h_bg_without_tikv
|
/run-all-tests |
|
/run-all-tests |
CalvinNeo
removed
the
needs-rebase
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref #7564
Problem Summary:
This is the first part of #7756.
#7756 is hard to be merged in bulk since our TiKV pr is still pending review.
However, we can still take advantage of changing interval-based passive flush into raft log gap based passive flush.
Meanwhile, since we have resolved conflicts with the master branch for many times, we also want to add some utilities here to reduce the size of later PRs.
What is changed and how it works?
Check List
Tests
The original integration test is enough.
It is tested under workload of 17kops in a 720 GiB table.
It is tested with frequent restart and then check consistency.
Side effects
Documentation
Release note