-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: Fix snap after dropping database #8560
ddl: Fix snap after dropping database #8560
Conversation
/run-all-tests |
/run-all-tests |
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hongyunyan, Lloyd-Pottiger The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/run-all-tests |
/run-integration-test |
|
/run-integration-test |
1 similar comment
/run-integration-test |
@JaySon-Huang: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests
If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #8506
Problem Summary:
Introduced by #8536. In that PR, we don't check whether the
DatabaseInfo
exist when creating a Storage instance.However, if the DDL "create database" and decoding raftlog or snapshot comes after TiDB executed "drop database". Then
applyCreateStorageInstance
can not handle it because theIDatabase
instance is not created in TiFlash.What is changed and how it works?
In order to resolve the
DatabaseInfo
can not be fetched from TiKV, we will construct a "fake"DatabaseInfo
and create theIDatabase
instance in TiFlash. BecauseFLASHBACK
, then we don't care its display name in TiFlash, we just need it for storing the raft log / snapshot dataFLASHBACK
later, then theDatabaseInfo
will be overwrittenCheck List
Tests
Side effects
Documentation
Release note