Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storages: Fix cloning delta index when there are duplicated tuples (#9000) #9018

Merged
merged 3 commits into from
May 16, 2024
Merged

Storages: Fix cloning delta index when there are duplicated tuples (#9000) #9018

merged 3 commits into from
May 16, 2024

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #9000

What problem does this PR solve?

Issue Number: close #8845

What is changed and how it works?

  1. Add a max_dup_tuple_id in DeltaTree.h.
  2. Record the max duplucated tuple id in DeltaPlace.h.
  3. Make sure the snapshot includes all duplicated tuples in the delta index when cloning the delta index in DeltaIndex.h.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Fix the potential issue that tiflash returns transient inconsistent results under high concurrent read

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Apr 30, 2024
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 30, 2024
Merged
12 tasks
@ti-chi-bot ti-chi-bot added cherry-pick-approved Cherry pick PR approved by release team. labels Apr 30, 2024
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed do-not-merge/cherry-pick-not-approved size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 30, 2024
@JinheLin
This is an automated cherry-pick of pingcap#9000
b6c6856 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@JinheLin
Resolve conflict
ff4aa41
@JinheLin JinheLin force-pushed the cherry-pick-9000-to-release-7.5 branch from 3901df1 to ff4aa41 Compare May 8, 2024 09:54
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 8, 2024
@JaySon-Huang
Copy link
Contributor

/run-all-tests

1 similar comment
@JaySon-Huang
Copy link
Contributor

/run-all-tests

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels May 16, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label May 16, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JaySon-Huang, JinheLin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JaySon-Huang,JinheLin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label May 16, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 16, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-16 05:19:28.785601912 +0000 UTC m=+1716922.542737477: ☑️ agreed by JinheLin.
  • 2024-05-16 05:29:11.012956311 +0000 UTC m=+1717504.770091884: ☑️ agreed by JaySon-Huang.

@JaySon-Huang
Copy link
Contributor

/run-all-tests

@JinheLin
Copy link
Contributor

/run-integration-test

@ti-chi-bot ti-chi-bot bot merged commit 28b4c22 into pingcap:release-7.5 May 16, 2024
5 checks passed
JaySon-Huang pushed a commit to JaySon-Huang/tiflash that referenced this pull request Aug 2, 2024
@ti-chi-bot @JaySon-Huang
Storages: Fix cloning delta index when there are duplicated tuples (p…
5cd6c72 
…ingcap#9000) (pingcap#9018)

close pingcap#8845
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JinheLin JinheLin JinheLin approved these changes

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

Assignees

@JinheLin JinheLin

Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ti-chi-bot @JaySon-Huang @JinheLin