-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sink(ticdc): remove force consume when redo is disabled #5712
sink(ticdc): remove force consume when redo is disabled #5712
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-all-tests |
/cc @hi-rustin @hicqu |
a86e382
to
fe9c91f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you add some comments to explain the method to solve the problem
Done, PTAL. |
/hold |
e4ba9d5
to
4ef0e31
Compare
/run-all-tests |
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## master #5712 +/- ##
================================================
+ Coverage 56.9653% 57.0635% +0.0982%
================================================
Files 681 682 +1
Lines 79903 79995 +92
================================================
+ Hits 45517 45648 +131
+ Misses 30106 30069 -37
+ Partials 4280 4278 -2 |
/unhold |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 4ef0e31
|
What problem does this PR solve?
Issue Number: close #5453, close #1683
What is changed and how it works?
In order to solve the OOM problem of single table, we refactor flowControl and Sink modules on the basis of splitting transaction, so that they can obtain data in batches and send it to the downstream, which reduces the memory consumption of individual table to constant level:
Check List
Tests
The results show that memory consumption of single table is constant. However, a lower quota value may affect throughput, so it is recommended to increase the quota of single tables to 30-40 MB.
up-TiCDC_2022-06-06T10_33_19.155Z.json.zip
heap_profile.zip
Questions
Will it cause performance regression or break compatibility?
No
Do you need to update user documentation, design documentation or monitoring documentation?
No
Release note