Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix oom cause missing data bug #2010

Merged
merged 1 commit into from
Apr 9, 2021
Merged

fix oom cause missing data bug #2010

merged 1 commit into from
Apr 9, 2021

Conversation

marsishandsome
Copy link
Collaborator

@marsishandsome marsishandsome commented Apr 9, 2021 •
edited
Loading

What problem does this PR solve?

oom during calling client.coprocess will cause missing data bug!

What is changed and how it works?

should not set eof = true if oom occures during calling client.coprocess

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to update the tidb-ansible repository
  • Need to be included in the release note

@marsishandsome marsishandsome added needs-cherry-pick-2.1 needs-cherry-pick-master PR which needs to be cherry-picked to master needs-cherry-pick-release-2.4 PR which needs to be cherry-picked to release-2.4 labels Apr 9, 2021
@marsishandsome
Copy link
Collaborator Author

/run-all-tests

@marsishandsome marsishandsome merged commit ad6abe4 into pingcap:release-2.3 Apr 9, 2021
@ti-srebot ti-srebot mentioned this pull request Apr 9, 2021
Merged
@ti-srebot
Copy link
Collaborator

cherry pick to release-2.1 in PR #2012

@ti-srebot ti-srebot mentioned this pull request Apr 9, 2021
Merged
@ti-srebot
Copy link
Collaborator

cherry pick to release-2.4 in PR #2013

@ti-srebot ti-srebot mentioned this pull request Apr 9, 2021
Merged
@ti-srebot
Copy link
Collaborator

cherry pick to master in PR #2014

@marsishandsome marsishandsome mentioned this pull request Apr 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@birdstorm birdstorm Awaiting requested review from birdstorm

Assignees
No one assigned
Labels
needs-cherry-pick-master PR which needs to be cherry-picked to master needs-cherry-pick-release-2.4 PR which needs to be cherry-picked to release-2.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marsishandsome @ti-srebot