Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

delete trove4j #2732

Merged
merged 2 commits into from
Jul 24, 2023
Merged

delete trove4j #2732

merged 2 commits into from
Jul 24, 2023

Conversation

shiyuhang0
Copy link
Member

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to update the tidb-ansible repository
  • Need to be included in the release note

@ti-chi-bot ti-chi-bot bot requested a review from Daemonxiao July 20, 2023 15:31
@ti-chi-bot ti-chi-bot bot added the size/XS label Jul 20, 2023
@shiyuhang0
Copy link
Member Author

/run-all-tests

@shiyuhang0
Copy link
Member Author

/run-all-tests

@ti-chi-bot ti-chi-bot bot added size/S and removed size/XS labels Jul 20, 2023
@shiyuhang0
Copy link
Member Author

/run-all-tests

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xuanyu66, zhangyangyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jul 24, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 24, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-07-21 03:47:04.040136237 +0000 UTC m=+1254115.810474950: ☑️ agreed by zhangyangyu.
  • 2023-07-24 06:27:01.421368793 +0000 UTC m=+162964.015899765: ☑️ agreed by xuanyu66.

@ti-chi-bot ti-chi-bot bot merged commit 1fd6538 into pingcap:master Jul 24, 2023
11 checks passed
@shiyuhang0 shiyuhang0 added needs-cherry-pick-release-2.4 PR which needs to be cherry-picked to release-2.4 needs-cherry-pick-release-2.5 PR which needs to be cherry-picked to release-2.5 needs-cherry-pick-release-3.0 PR which needs to be cherry-picked to release-2.5 needs-cherry-pick-release-3.1 PR which needs to be cherry-picked to release-3.1 needs-cherry-pick-release-3.2 labels Jul 24, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 24, 2023
Closed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-2.4: #2733.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-3.0: #2734.

ti-chi-bot pushed a commit to ti-chi-bot/tispark that referenced this pull request Jul 24, 2023
@shiyuhang0 @ti-chi-bot
This is an automated cherry-pick of pingcap#2732
66cd6be 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
This was referenced Jul 24, 2023
Closed
Closed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-2.5: #2735.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-3.1: #2736.

ti-chi-bot pushed a commit to ti-chi-bot/tispark that referenced this pull request Jul 24, 2023
@shiyuhang0 @ti-chi-bot
This is an automated cherry-pick of pingcap#2732
b7b89f6 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot pushed a commit to ti-chi-bot/tispark that referenced this pull request Jul 24, 2023
@shiyuhang0 @ti-chi-bot
This is an automated cherry-pick of pingcap#2732
651887c 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
This was referenced Jul 24, 2023
Closed
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-3.2: #2737.

ti-chi-bot pushed a commit to ti-chi-bot/tispark that referenced this pull request Jul 24, 2023
@shiyuhang0 @ti-chi-bot
This is an automated cherry-pick of pingcap#2732
815e00b 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot pushed a commit to ti-chi-bot/tispark that referenced this pull request Jul 24, 2023
@shiyuhang0 @ti-chi-bot
This is an automated cherry-pick of pingcap#2732
d0ea49b 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@zhangyangyu zhangyangyu deleted the delete_trove4j branch July 24, 2023 09:17
shiyuhang0 added a commit that referenced this pull request Aug 2, 2023
@ti-chi-bot @shiyuhang0
delete trove4j (#2732) (#2737)
8d8275e 
* This is an automated cherry-pick of #2732

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

* Update pom.xml

---------

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Co-authored-by: shi yuhang <52435083+shiyuhang0@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhangyangyu zhangyangyu zhangyangyu approved these changes

@xuanyu66 xuanyu66 xuanyu66 approved these changes

@Daemonxiao Daemonxiao Awaiting requested review from Daemonxiao

Assignees
No one assigned
Labels
approved lgtm needs-cherry-pick-release-2.4 PR which needs to be cherry-picked to release-2.4 needs-cherry-pick-release-2.5 PR which needs to be cherry-picked to release-2.5 needs-cherry-pick-release-3.0 PR which needs to be cherry-picked to release-2.5 needs-cherry-pick-release-3.1 PR which needs to be cherry-picked to release-3.1 needs-cherry-pick-release-3.2 size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shiyuhang0 @ti-chi-bot @zhangyangyu @xuanyu66