-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: decode json to string #417
Conversation
- just map json to String
Hi contributor, thanks for your PR. This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically. |
Codecov Report
@@ Coverage Diff @@
## master #417 +/- ##
=========================================
Coverage ? 54.01%
=========================================
Files ? 128
Lines ? 5965
Branches ? 889
=========================================
Hits ? 3222
Misses ? 2446
Partials ? 297
Continue to review full report at Codecov.
|
Hi, @alex-lx. Please let me express my gratitude to your brilliant patch. I think you could add some tests concerning JSON types, you may refer to some existing tests in IssueTestSuite. I will start the review now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, LGTM as long as corresponding tests are added. Or I could add it for you, what do you think? @alex-lx
@birdstorm, thanks for your review. I will add the test soon. |
Hello, @birdstorm. Test added, Please take a look. |
Hi contributor, thanks for your PR. This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically. |
/ok-to-test |
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please resolve test fails.
Sorry, I can‘t reproduce the failure in my environment. I think it may cause by the version of tidb. Would you mind if the test does not use |
@alex-lx Of course, I will handle this test failure. Thanks again for your contribution. |
/run-all-tests |
Test fails due to pingcap/tidb#7389 |
/run-all-tests |
Convert JSON from binary format to String format. see example below