-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cannot initialize pd if using ipv6 address #587
Conversation
/run-all-tests |
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #587 +/- ##
=========================================
Coverage ? 52.74%
Complexity ? 956
=========================================
Files ? 135
Lines ? 6404
Branches ? 760
=========================================
Hits ? 3378
Misses ? 2720
Partials ? 306
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Previously: if the pd is using an ipv6 address, HostAndPort cannot resolve address correctly.