Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cannot initialize pd if using ipv6 address #587

Merged
merged 3 commits into from
Mar 5, 2019
Merged

Conversation

birdstorm
Copy link
Contributor

Previously: if the pd is using an ipv6 address, HostAndPort cannot resolve address correctly.

@birdstorm birdstorm requested a review from zhexuany March 5, 2019 10:01
@birdstorm
Copy link
Contributor Author

/run-all-tests

@birdstorm
Copy link
Contributor Author

/run-all-tests

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@c891da3). Click here to learn what that means.
The diff coverage is 81.25%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #587   +/-   ##
=========================================
  Coverage          ?   52.74%           
  Complexity        ?      956           
=========================================
  Files             ?      135           
  Lines             ?     6404           
  Branches          ?      760           
=========================================
  Hits              ?     3378           
  Misses            ?     2720           
  Partials          ?      306
Impacted Files Coverage Δ Complexity Δ
...nt/src/main/java/com/pingcap/tikv/codec/Codec.java 90.36% <ø> (ø) 2 <0> (?)
...rc/main/java/com/pingcap/tikv/TiConfiguration.java 53.75% <100%> (ø) 17 <0> (?)
...main/java/com/pingcap/tikv/util/RangeSplitter.java 65.78% <100%> (ø) 19 <0> (?)
...ient/src/main/java/com/pingcap/tikv/TiSession.java 68.35% <66.66%> (ø) 15 <0> (?)
...lient/src/main/java/com/pingcap/tikv/PDClient.java 84.17% <75%> (ø) 36 <5> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c891da3...fc26b69. Read the comment docs.

Copy link
Contributor

@zhexuany zhexuany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhexuany zhexuany merged commit 22abbd4 into master Mar 5, 2019
@zhexuany zhexuany deleted the fix-ipv6-address branch March 5, 2019 13:18
wfxxh pushed a commit to wanfangdata/tispark that referenced this pull request Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants