Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix column size estimation (#858) #884

Merged
merged 1 commit into from
Jul 1, 2019
Merged

Fix column size estimation (#858) #884

merged 1 commit into from
Jul 1, 2019

Conversation

birdstorm
Copy link
Contributor

Cherry-pick #858

@birdstorm
Copy link
Contributor Author

/run-all-tests

add TiKVException to resolve conflict
@birdstorm
Copy link
Contributor Author

/run-all-tests

Copy link
Collaborator

@marsishandsome marsishandsome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (2.1@dfa7cca). Click here to learn what that means.
The diff coverage is 74.69%.

Impacted file tree graph

@@          Coverage Diff           @@
##             2.1     #884   +/-   ##
======================================
  Coverage       ?   53.45%           
  Complexity     ?     1114           
======================================
  Files          ?      151           
  Lines          ?     7002           
  Branches       ?      816           
======================================
  Hits           ?     3743           
  Misses         ?     2894           
  Partials       ?      365
Impacted Files Coverage Δ Complexity Δ
.../tikv/expression/visitor/IndexRangeSetBuilder.java 48% <0%> (ø) 4 <0> (?)
...java/com/pingcap/tikv/exception/TiKVException.java 0% <0%> (ø) 0 <0> (?)
.../src/main/java/com/pingcap/tikv/types/BitType.java 42.85% <0%> (ø) 3 <0> (?)
...t/src/main/java/com/pingcap/tikv/key/TypedKey.java 34.21% <0%> (ø) 5 <0> (?)
.../src/main/java/com/pingcap/tikv/types/SetType.java 42.42% <100%> (ø) 6 <0> (?)
...rc/main/java/com/pingcap/tikv/types/BytesType.java 76.66% <100%> (ø) 10 <2> (?)
...c/main/java/com/pingcap/tikv/meta/TiTableInfo.java 41.25% <100%> (ø) 16 <2> (?)
...main/java/com/pingcap/tikv/meta/TiIndexColumn.java 76.92% <100%> (ø) 7 <1> (?)
.../main/java/com/pingcap/tikv/meta/TiColumnInfo.java 58.77% <100%> (ø) 21 <1> (?)
.../com/pingcap/tikv/predicates/TiKVScanAnalyzer.java 57.07% <50%> (ø) 31 <0> (?)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfa7cca...3c29d2d. Read the comment docs.

@birdstorm birdstorm merged commit ff461e0 into 2.1 Jul 1, 2019
@birdstorm birdstorm deleted the cherry-pick-#858 branch July 1, 2019 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants