Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use cobra default auto completion #1549

Merged
merged 1 commit into from
Sep 3, 2021

Conversation

nexustar
Copy link
Collaborator

@nexustar nexustar commented Sep 3, 2021

What problem does this PR solve?

cobra support auto completion command since 1.2 https://github.com/spf13/cobra/releases/tag/v1.2.0

What is changed and how it works?

use cobra build-in auto completion

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Release notes:

NONE

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 3, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AstroProfundis

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 3, 2021
@codecov-commenter
Copy link

codecov-commenter commented Sep 3, 2021

Codecov Report

Merging #1549 (6bce0c7) into master (551e758) will increase coverage by 26.77%.
The diff coverage is n/a.

❗ Current head 6bce0c7 differs from pull request most recent head 2e859b0. Consider uploading reports for the commit 2e859b0 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1549       +/-   ##
===========================================
+ Coverage   26.27%   53.04%   +26.77%     
===========================================
  Files         267      290       +23     
  Lines       24146    26114     +1968     
===========================================
+ Hits         6344    13852     +7508     
+ Misses      16984    10401     -6583     
- Partials      818     1861     +1043     
Flag Coverage Δ
cluster 43.85% <ø> (?)
dm 26.18% <ø> (?)
integrate 47.54% <ø> (+31.39%) ⬆️
playground 13.78% <ø> (?)
tiup ?
unittest 22.75% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/root.go 23.94% <ø> (-49.49%) ⬇️
main.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/repository/utils/hash.go 0.00% <0.00%> (-83.34%) ⬇️
pkg/repository/model/publish.go 0.00% <0.00%> (-83.34%) ⬇️
cmd/env.go 27.77% <0.00%> (-66.67%) ⬇️
pkg/utils/args.go 0.00% <0.00%> (-50.00%) ⬇️
pkg/repository/model/model.go 0.00% <0.00%> (-47.52%) ⬇️
pkg/repository/v1manifest/repo.go 0.00% <0.00%> (-47.50%) ⬇️
cmd/uninstall.go 30.88% <0.00%> (-44.12%) ⬇️
... and 237 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 551e758...2e859b0. Read the comment docs.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 3, 2021
@AstroProfundis AstroProfundis added this to the v1.6.0 milestone Sep 3, 2021
@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 2e859b0

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 3, 2021
@ti-chi-bot ti-chi-bot merged commit 562140c into pingcap:master Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants