Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: make manage_host editable #2210

Merged
merged 1 commit into from
Jun 12, 2023

Conversation

nexustar
Copy link
Collaborator

@nexustar nexustar commented Jun 9, 2023

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot ti-chi-bot bot requested review from breezewish and srstack June 9, 2023 06:03
@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 9, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jun 9, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.21 ⚠️

Comparison is base (1940b27) 56.18% compared to head (7ec5f87) 55.97%.

❗ Current head 7ec5f87 differs from pull request most recent head 5489705. Consider uploading reports for the commit 5489705 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2210      +/-   ##
==========================================
- Coverage   56.18%   55.97%   -0.21%     
==========================================
  Files         320      320              
  Lines       33667    33667              
==========================================
- Hits        18913    18843      -70     
- Misses      12494    12567      +73     
+ Partials     2260     2257       -3     
Flag Coverage Δ
cluster 44.98% <ø> (-0.24%) ⬇️
dm 25.99% <ø> (ø)
playground 15.70% <ø> (-0.02%) ⬇️
tiup 15.95% <ø> (-0.02%) ⬇️
unittest 22.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/dm/spec/topology_dm.go 81.79% <ø> (ø)
pkg/cluster/spec/alertmanager.go 67.54% <ø> (ø)
pkg/cluster/spec/cdc.go 57.22% <ø> (-0.52%) ⬇️
pkg/cluster/spec/dashboard.go 4.63% <ø> (ø)
pkg/cluster/spec/drainer.go 55.68% <ø> (ø)
pkg/cluster/spec/grafana.go 63.68% <ø> (ø)
pkg/cluster/spec/monitoring.go 76.04% <ø> (ø)
pkg/cluster/spec/pd.go 66.43% <ø> (ø)
pkg/cluster/spec/pump.go 62.07% <ø> (ø)
pkg/cluster/spec/tidb.go 67.50% <ø> (ø)
... and 4 more

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ti-chi-bot ti-chi-bot bot added the lgtm label Jun 9, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 9, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-06-09 18:17:07.242247384 +0000 UTC m=+108641.490169195: ☑️ agreed by srstack.

@wuhuizuo
Copy link
Contributor

/merge

just for test

@wuhuizuo
Copy link
Contributor

/merge

1 similar comment
@wuhuizuo
Copy link
Contributor

/merge

@kaaaaaaang kaaaaaaang added this to the 1.12.3 milestone Jun 12, 2023
@kaaaaaaang
Copy link
Collaborator

/merge

@kaaaaaaang
Copy link
Collaborator

/approve

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaaaaaaang, srstack

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jun 12, 2023
@ti-chi-bot ti-chi-bot bot merged commit ea3af77 into pingcap:master Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants