Component source

[nexustar]

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code

Code changes

• Has exported function/method change
• Has exported variable/fields change
• Has interface methods change
• Has persistent data change

Side effects

• Possible performance regression
• Increased code complexity
• Breaking backward compatibility

Related changes

• Need to cherry-pick to the release branch
• Need to update the documentation

Release notes:

NONE

[codecov-commenter]

Codecov Report

Patch coverage: 71.28% and project coverage change: +0.06% 🎉

Comparison is base (0d229e9) 55.91% compared to head (b853058) 55.97%.

❗ Current head b853058 differs from pull request most recent head cbda852. Consider uploading reports for the commit cbda852 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2236      +/-   ##
==========================================
+ Coverage   55.91%   55.97%   +0.06%     
==========================================
  Files         320      320              
  Lines       33795    33866      +71     
==========================================
+ Hits        18895    18955      +60     
- Misses      12631    12641      +10     
- Partials     2269     2270       +1     

Flag	Coverage Δ
cluster	44.82% <68.29%> (+0.08%)	⬆️
dm	25.69% <30.85%> (-0.01%)	⬇️
playground	15.74% <0.00%> (-0.03%)	⬇️
tiup	15.88% <0.00%> (-0.05%)	⬇️
unittest	22.66% <23.40%> (+0.02%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
pkg/cluster/spec/dashboard.go	4.39% <0.00%> (-0.24%)	⬇️
pkg/cluster/spec/tidb.go	65.66% <28.57%> (-1.84%)	⬇️
pkg/cluster/spec/tikv.go	60.98% <28.57%> (-0.78%)	⬇️
pkg/cluster/spec/server_config.go	72.27% <66.67%> (ø)
components/dm/spec/topology_dm.go	81.75% <80.00%> (-0.03%)	⬇️
pkg/cluster/manager/upgrade.go	57.29% <80.00%> (ø)
pkg/cluster/spec/cdc.go	58.00% <83.33%> (+0.78%)	⬆️
pkg/cluster/spec/pump.go	62.78% <83.33%> (+0.71%)	⬆️
pkg/cluster/spec/tiflash.go	68.50% <83.33%> (-0.02%)	⬇️
pkg/cluster/spec/tikv_cdc.go	49.44% <83.33%> (+1.18%)	⬆️
... and 9 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaaaaaaang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [kaaaaaaang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2023-08-09 10:34:55.110076005 +0000 UTC m=+108859.659091986: ☑️ agreed by kaaaaaaang.

[kaaaaaaang]

/merge