Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster/dm: support ignore version check when upgrade #2282

Merged
merged 2 commits into from
Sep 25, 2023

Conversation

nexustar
Copy link
Collaborator

@nexustar nexustar commented Sep 21, 2023

What problem does this PR solve?

What is changed and how it works?

image

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 21, 2023
@nexustar nexustar added this to the v1.13.1 milestone Sep 21, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 21, 2023

Codecov Report

Patch coverage: 63.64% and project coverage change: -0.05% ⚠️

Comparison is base (9d1ba4b) 55.80% compared to head (38a15fe) 55.75%.

❗ Current head 38a15fe differs from pull request most recent head 13852d8. Consider uploading reports for the commit 13852d8 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2282      +/-   ##
==========================================
- Coverage   55.80%   55.75%   -0.05%     
==========================================
  Files         323      323              
  Lines       34095    34100       +5     
==========================================
- Hits        19026    19012      -14     
- Misses      12795    12814      +19     
  Partials     2274     2274              
Flag Coverage Δ
cluster 44.77% <50.00%> (-0.05%) ⬇️
dm 25.71% <50.00%> (+<0.01%) ⬆️
playground 15.68% <ø> (-0.02%) ⬇️
tiup 15.88% <ø> (ø)
unittest 22.61% <36.36%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/cluster/manager/upgrade.go 56.72% <20.00%> (-0.57%) ⬇️
components/cluster/command/upgrade.go 66.67% <100.00%> (+1.96%) ⬆️
components/dm/command/upgrade.go 57.14% <100.00%> (+2.14%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kaaaaaaang
Copy link
Collaborator

/lgtm

@ti-chi-bot ti-chi-bot bot added the lgtm label Sep 25, 2023
@kaaaaaaang
Copy link
Collaborator

/approve

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaaaaaaang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Sep 25, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 25, 2023

@nexustar: Your PR was out of date, I have automatically updated it for you.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot removed the lgtm label Sep 25, 2023
@kaaaaaaang
Copy link
Collaborator

/lgtm

@ti-chi-bot ti-chi-bot bot added the lgtm label Sep 25, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 25, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-25 08:17:37.602036866 +0000 UTC m=+262847.320379069: ☑️ agreed by kaaaaaaang.
  • 2023-09-25 08:17:56.638974863 +0000 UTC m=+262866.357317078: ✖️🔁 reset by ti-chi-bot[bot].
  • 2023-09-25 08:39:25.239266016 +0000 UTC m=+264154.957608222: ☑️ agreed by kaaaaaaang.

@ti-chi-bot ti-chi-bot bot merged commit f3b0806 into pingcap:master Sep 25, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants