Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster/dm: add gloabl listen_host #2303

Merged
merged 2 commits into from
Nov 8, 2023

Conversation

nexustar
Copy link
Collaborator

@nexustar nexustar commented Nov 7, 2023

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 7, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (eb2f058) 54.97% compared to head (3c40765) 50.36%.

❗ Current head 3c40765 differs from pull request most recent head 6cecc2e. Consider uploading reports for the commit 6cecc2e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2303      +/-   ##
==========================================
- Coverage   54.97%   50.36%   -4.61%     
==========================================
  Files         326      326              
  Lines       34700    34711      +11     
==========================================
- Hits        19075    17481    -1594     
- Misses      13342    15124    +1782     
+ Partials     2283     2106     -177     
Flag Coverage Δ
cluster 35.30% <84.62%> (-9.29%) ⬇️
tiup 15.56% <0.00%> (-0.01%) ⬇️
unittest 22.33% <53.33%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/cluster/spec/alertmanager.go 64.80% <100.00%> (+2.40%) ⬆️
pkg/cluster/spec/cdc.go 42.45% <100.00%> (-12.05%) ⬇️
pkg/cluster/spec/drainer.go 49.74% <100.00%> (-4.43%) ⬇️
pkg/cluster/spec/grafana.go 61.70% <100.00%> (+0.16%) ⬆️
pkg/cluster/spec/monitoring.go 72.15% <100.00%> (-0.99%) ⬇️
pkg/cluster/spec/pd.go 38.44% <100.00%> (-26.19%) ⬇️
pkg/cluster/spec/pump.go 48.69% <100.00%> (-17.10%) ⬇️
pkg/cluster/spec/spec.go 80.80% <ø> (-2.80%) ⬇️
pkg/cluster/spec/tidb.go 50.28% <100.00%> (-11.30%) ⬇️
pkg/cluster/spec/tiflash.go 66.07% <100.00%> (-1.90%) ⬇️
... and 5 more

... and 49 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

ti-chi-bot bot commented Nov 8, 2023

@KanShiori: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kaaaaaaang
Copy link
Collaborator

/lgtm

@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 8, 2023
Copy link
Contributor

ti-chi-bot bot commented Nov 8, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-08 03:00:22.526273533 +0000 UTC m=+3613220.113383670: ☑️ agreed by kaaaaaaang.

@kaaaaaaang
Copy link
Collaborator

/approve

Copy link
Contributor

ti-chi-bot bot commented Nov 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaaaaaaang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 8, 2023
@ti-chi-bot ti-chi-bot bot merged commit 2eaf957 into pingcap:master Nov 8, 2023
18 checks passed
@kaaaaaaang kaaaaaaang added this to the v1.14.0 milestone Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tiflash not support config listen_host cluster/dm: add global listen_host config
4 participants