Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

playground/log: add mcs name for pd log #2310

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

HuSharp
Copy link
Contributor

@HuSharp HuSharp commented Nov 10, 2023

What problem does this PR solve?

What is changed and how it works?

change log name for pd mcs

run ./tiup-playground nightly --pd.mode ms --pd.api 3 --pd.tso 2 --pd.rm 1
before
image

after
image

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Release notes:

NONE

@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 10, 2023
@HuSharp
Copy link
Contributor Author

HuSharp commented Nov 10, 2023

cc @rleungx PTAL, thx!

@CLAassistant
Copy link

CLAassistant commented Nov 10, 2023

CLA assistant check
All committers have signed the CLA.

Signed-off-by: husharp <jinhao.hu@pingcap.com>
@codecov-commenter
Copy link

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (da0221a) 53.39% compared to head (4dd84c7) 29.96%.

❗ Current head 4dd84c7 differs from pull request most recent head a756742. Consider uploading reports for the commit a756742 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2310       +/-   ##
===========================================
- Coverage   53.39%   29.96%   -23.43%     
===========================================
  Files         325      311       -14     
  Lines       34725    32173     -2552     
===========================================
- Hits        18540     9640     -8900     
- Misses      13937    21447     +7510     
+ Partials     2248     1086     -1162     
Flag Coverage Δ
cluster ?
dm ?
playground 15.24% <0.00%> (-0.05%) ⬇️
tiup 33.47% <ø> (ø)
unittest 22.37% <0.00%> (-<0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
components/playground/instance/pd.go 48.72% <ø> (ø)
components/playground/playground.go 43.84% <0.00%> (-0.16%) ⬇️

... and 204 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kaaaaaaang
Copy link
Collaborator

/lgtm

@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 13, 2023
Copy link
Contributor

ti-chi-bot bot commented Nov 13, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-13 07:54:05.107429941 +0000 UTC m=+4062842.694540071: ☑️ agreed by kaaaaaaang.

@kaaaaaaang
Copy link
Collaborator

/approve

Copy link
Contributor

ti-chi-bot bot commented Nov 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaaaaaaang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 13, 2023
@kaaaaaaang kaaaaaaang added this to the v1.14.0 milestone Nov 13, 2023
@ti-chi-bot ti-chi-bot bot merged commit 3199925 into pingcap:master Nov 13, 2023
5 of 6 checks passed
@HuSharp HuSharp deleted the add_log_for_pd_mcs branch November 13, 2023 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants