Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

playground: Fix alignment of output #2313

Merged
merged 2 commits into from
Nov 15, 2023

Conversation

dveeden
Copy link
Contributor

@dveeden dveeden commented Nov 14, 2023

What problem does this PR solve?

tiup playground --tiproxy 1 v7.1.2:

Without this PR:

Connect TiDB:    mysql --comments --host 127.0.0.1 --port 4000 -u root
Connect TiProxy: mysql --comments --host 127.0.0.1 --port 6000 -u root
TiDB Dashboard:  http://127.0.0.1:2379/dashboard
Grafana:        http://127.0.0.1:3000

With this PR:

Connect TiDB:    mysql --comments --host 127.0.0.1 --port 4000 -u root
Connect TiProxy: mysql --comments --host 127.0.0.1 --port 36243 -u root
TiDB Dashboard:  http://127.0.0.1:2379/dashboard
Grafana:         http://127.0.0.1:3000

The line with Grafana: isn't aligned correctly

What is changed and how it works?

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Related changes

  • Need to cherry-pick to the release branch

Release notes:

NONE

@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 14, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (621598e) 55.52% compared to head (64e4082) 55.52%.

❗ Current head 64e4082 differs from pull request most recent head 772f6f7. Consider uploading reports for the commit 772f6f7 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2313   +/-   ##
=======================================
  Coverage   55.52%   55.52%           
=======================================
  Files         325      325           
  Lines       34725    34725           
=======================================
  Hits        19281    19281           
  Misses      13142    13142           
  Partials     2302     2302           
Flag Coverage Δ
playground 15.25% <100.00%> (ø)
tiup 33.48% <ø> (ø)
unittest 22.38% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kaaaaaaang
Copy link
Collaborator

/lgtm

@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 15, 2023
@kaaaaaaang
Copy link
Collaborator

/approve

Copy link
Contributor

ti-chi-bot bot commented Nov 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaaaaaaang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 15, 2023
@kaaaaaaang kaaaaaaang added this to the v1.14.0 milestone Nov 15, 2023
@ti-chi-bot ti-chi-bot bot removed the lgtm label Nov 15, 2023
Copy link
Contributor

ti-chi-bot bot commented Nov 15, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-15 05:46:07.663554448 +0000 UTC m=+4227965.250664602: ☑️ agreed by kaaaaaaang.
  • 2023-11-15 05:46:25.366744708 +0000 UTC m=+4227982.953854854: ✖️🔁 reset by ti-chi-bot[bot].

Copy link
Contributor

ti-chi-bot bot commented Nov 15, 2023

New changes are detected. LGTM label has been removed.

@kaaaaaaang
Copy link
Collaborator

/lgtm /approve

@kaaaaaaang kaaaaaaang merged commit bff409d into pingcap:master Nov 15, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants