Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

playground: fallback to default version when componen specific version is empty #2344

Merged
merged 1 commit into from
Dec 28, 2023

Conversation

xhebox
Copy link
Collaborator

@xhebox xhebox commented Dec 28, 2023

What problem does this PR solve?

Close #2343 . Fallback to default version when componen specific version is empty

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

Signed-off-by: xhe <xw897002528@gmail.com>
@ti-chi-bot ti-chi-bot bot requested a review from srstack December 28, 2023 08:07
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 28, 2023
@codecov-commenter
Copy link

codecov-commenter commented Dec 28, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (5618124) 53.39% compared to head (95bb130) 53.38%.

❗ Current head 95bb130 differs from pull request most recent head 90147f3. Consider uploading reports for the commit 90147f3 to get more accurate results

Files Patch % Lines
components/playground/playground.go 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2344      +/-   ##
==========================================
- Coverage   53.39%   53.38%   -0.01%     
==========================================
  Files         328      328              
  Lines       34825    34828       +3     
==========================================
- Hits        18593    18592       -1     
- Misses      13973    13976       +3     
- Partials     2259     2260       +1     
Flag Coverage Δ
playground 15.31% <83.33%> (+0.01%) ⬆️
tiup 33.56% <ø> (-0.05%) ⬇️
unittest 22.35% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kaaaaaaang
Copy link
Collaborator

/lgtm

@ti-chi-bot ti-chi-bot bot added the lgtm label Dec 28, 2023
Copy link
Contributor

ti-chi-bot bot commented Dec 28, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-28 08:17:06.35516052 +0000 UTC m=+1726517.392387434: ☑️ agreed by kaaaaaaang.

@kaaaaaaang
Copy link
Collaborator

/approve

Copy link
Contributor

ti-chi-bot bot commented Dec 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaaaaaaang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Dec 28, 2023
@ti-chi-bot ti-chi-bot bot merged commit 48b5119 into pingcap:master Dec 28, 2023
7 checks passed
@kaaaaaaang kaaaaaaang added this to the v1.14.1 milestone Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TiUP playground doesn't download the nightly TiProxy
3 participants