-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cluster: skip tiproxy download & copy #2366
Conversation
Signed-off-by: xhe <xw897002528@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2366 +/- ##
==========================================
- Coverage 56.07% 55.94% -0.13%
==========================================
Files 329 329
Lines 35034 35040 +6
==========================================
- Hits 19644 19603 -41
- Misses 13053 13100 +47
Partials 2337 2337
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
/retest |
/lgtm |
/approve |
/lgtm |
/approve |
[LGTM Timeline notifier]Timeline:
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kaaaaaaang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Some components has different
Role()
andName()
.FilterComponent
is a mixed of filtering byName()
andRole()
, thus we need to add both into the filter set.Check List
Tests
Code changes
Side effects
Related changes
Release notes: