Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix timeout when checking component upgrade #2379

Conversation

KanShiori
Copy link
Collaborator

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot ti-chi-bot bot requested review from breezewish and nexustar March 1, 2024 08:54
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 1, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 50.09%. Comparing base (8164c78) to head (8d3f9dd).

❗ Current head 8d3f9dd differs from pull request most recent head e3423d9. Consider uploading reports for the commit e3423d9 to get more accurate results

Files Patch % Lines
pkg/exec/run.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2379      +/-   ##
==========================================
- Coverage   56.03%   50.09%   -5.95%     
==========================================
  Files         329      329              
  Lines       35032    35034       +2     
==========================================
- Hits        19630    17548    -2082     
- Misses      13063    15365    +2302     
+ Partials     2339     2121     -218     
Flag Coverage Δ
cluster 35.33% <ø> (-9.96%) ⬇️
dm 25.51% <ø> (ø)
tiup 33.59% <0.00%> (-0.01%) ⬇️
unittest 22.24% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@kaaaaaaang kaaaaaaang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot bot added the lgtm label Mar 1, 2024
Copy link
Contributor

ti-chi-bot bot commented Mar 1, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-01 09:00:42.803228302 +0000 UTC m=+1211731.550851407: ☑️ agreed by kaaaaaaang.

@kaaaaaaang
Copy link
Collaborator

/approve

Copy link
Contributor

ti-chi-bot bot commented Mar 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaaaaaaang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Mar 1, 2024
@ti-chi-bot ti-chi-bot bot merged commit bb648c3 into pingcap:master Mar 1, 2024
19 checks passed
@KanShiori KanShiori deleted the shiori/fix-timeout-when-upgrade-compoent-check branch March 1, 2024 09:05
@kaaaaaaang kaaaaaaang added this to the v1.15.0 milestone Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants