Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

playground: remove resource manager #2381

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Mar 12, 2024

What problem does this PR solve?

Resource manager microservice is never fully tested. So I'm going to remove it to avoid misleading the users.

What is changed and how it works?

Check List

Tests

  • Manual test (add detailed scripts or steps below)
$ bin/tiup-playground nightly --pd.mode ms --pd 3 --scheduling 2 --tso 2 --kv 6 --tiflash 0 --host 10.2.8.101
Start pd instance:v8.0.0-alpha-nightly
Start pd instance:v8.0.0-alpha-nightly
Start pd instance:v8.0.0-alpha-nightly
Start tso instance:v8.0.0-alpha-nightly
Start tso instance:v8.0.0-alpha-nightly
Start scheduling instance:v8.0.0-alpha-nightly
Start scheduling instance:v8.0.0-alpha-nightly
Start tikv instance:v8.0.0-alpha-nightly
Start tikv instance:v8.0.0-alpha-nightly
Start tikv instance:v8.0.0-alpha-nightly
Start tikv instance:v8.0.0-alpha-nightly
Start tikv instance:v8.0.0-alpha-nightly
Start tikv instance:v8.0.0-alpha-nightly
Start tidb instance:v8.0.0-alpha-nightly
Waiting for tidb instances ready
10.2.8.101:37777 ... Done
component grafana version v8.0.0-alpha-nightly is already installed

🎉 TiDB Playground Cluster is started, enjoy!

Connect TiDB:    mysql --comments --host 10.2.8.101 --port 37777 -u root
TiDB Dashboard:  http://10.2.8.101:38999/dashboard
Grafana:         http://10.2.8.101:39125

Side effects

  • Breaking backward compatibility

Release notes:

NONE

Signed-off-by: Ryan Leung <rleungx@gmail.com>
Copy link
Contributor

ti-chi-bot bot commented Mar 12, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kaaaaaaang for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 12, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 12, 2024

Codecov Report

Attention: Patch coverage is 41.93548% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 56.03%. Comparing base (9e11d0e) to head (e6a73dd).
Report is 4 commits behind head on master.

❗ Current head e6a73dd differs from pull request most recent head 7c18c80. Consider uploading reports for the commit 7c18c80 to get more accurate results

Files Patch % Lines
components/playground/main.go 40.00% 9 Missing ⚠️
components/playground/playground.go 22.22% 5 Missing and 2 partials ⚠️
components/playground/instance/instance.go 0.00% 0 Missing and 1 partial ⚠️
components/playground/instance/pd.go 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2381      +/-   ##
==========================================
- Coverage   56.07%   56.03%   -0.03%     
==========================================
  Files         329      329              
  Lines       35040    34998      -42     
==========================================
- Hits        19646    19611      -35     
+ Misses      13056    13050       -6     
+ Partials     2338     2337       -1     
Flag Coverage Δ
cluster 45.25% <100.00%> (-0.07%) ⬇️
dm 25.52% <100.00%> (-0.05%) ⬇️
playground 15.75% <38.71%> (-0.04%) ⬇️
tiup 33.59% <ø> (-0.05%) ⬇️
unittest 22.26% <0.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ti-chi-bot ti-chi-bot bot added the lgtm label Mar 12, 2024
Copy link
Contributor

ti-chi-bot bot commented Mar 12, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-12 09:19:57.055643897 +0000 UTC m=+763624.077890283: ☑️ agreed by srstack.

@kaaaaaaang
Copy link
Collaborator

/lgtm

@kaaaaaaang kaaaaaaang closed this Mar 27, 2024
@kaaaaaaang kaaaaaaang reopened this Mar 27, 2024
@kaaaaaaang kaaaaaaang merged commit aa448ad into pingcap:master Mar 27, 2024
21 of 33 checks passed
@rleungx rleungx deleted the remove-rm branch April 2, 2024 03:09
@kaaaaaaang kaaaaaaang modified the milestones: v1.16.0, v1.15.0 Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants