Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove uselesss println #2383

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

Lloyd-Pottiger
Copy link
Contributor

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
Copy link
Contributor

ti-chi-bot bot commented Mar 12, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kaaaaaaang for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 12, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 30.03%. Comparing base (9e11d0e) to head (c283e52).

❗ Current head c283e52 differs from pull request most recent head 6a10af8. Consider uploading reports for the commit 6a10af8 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2383       +/-   ##
===========================================
- Coverage   56.07%   30.03%   -26.04%     
===========================================
  Files         329      315       -14     
  Lines       35040    32462     -2578     
===========================================
- Hits        19646     9747     -9899     
- Misses      13056    21635     +8579     
+ Partials     2338     1080     -1258     
Flag Coverage Δ
cluster ?
dm ?
playground 15.79% <ø> (+0.01%) ⬆️
tiup 33.59% <ø> (-0.05%) ⬇️
unittest 22.23% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ti-chi-bot ti-chi-bot bot added the lgtm label Mar 13, 2024
Copy link
Contributor

ti-chi-bot bot commented Mar 13, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-13 04:01:30.576211242 +0000 UTC m=+830917.598457631: ☑️ agreed by breezewish.

@Lloyd-Pottiger
Copy link
Contributor Author

/assign @kaaaaaaang

@kaaaaaaang
Copy link
Collaborator

/lgtm

@kaaaaaaang kaaaaaaang merged commit 7327e75 into pingcap:master Mar 26, 2024
6 of 7 checks passed
@kaaaaaaang kaaaaaaang modified the milestones: v1.16.0, v1.15.0 Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants