Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: patch can't overwrite twice #558

Merged
merged 8 commits into from
Jul 7, 2020

Conversation

lucklove
Copy link
Member

@lucklove lucklove commented Jul 1, 2020

Fix #556

Signed-off-by: lucklove gnu.crazier@gmail.com

Fix pingcap#556

Signed-off-by: lucklove <gnu.crazier@gmail.com>
@CLAassistant
Copy link

CLAassistant commented Jul 1, 2020

CLA assistant check
All committers have signed the CLA.

@lucklove lucklove added the type/bug-fix Categorizes PR as a bug-fix label Jul 1, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jul 2, 2020

Codecov Report

Merging #558 into master will increase coverage by 10.41%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #558       +/-   ##
===========================================
+ Coverage   39.84%   50.26%   +10.41%     
===========================================
  Files         201      219       +18     
  Lines       14847    15877     +1030     
===========================================
+ Hits         5916     7980     +2064     
+ Misses       8072     6765     -1307     
- Partials      859     1132      +273     
Flag Coverage Δ
#coverage 50.26% <ø> (+10.41%) ⬆️
Impacted Files Coverage Δ
...o/src/github.com/pingcap/tiup/server/store/sync.go 28.57% <0.00%> (-28.58%) ⬇️
....com/pingcap/tiup/pkg/cluster/clusterutil/retry.go 50.00% <0.00%> (-17.50%) ⬇️
go/src/github.com/pingcap/tiup/cmd/mirror.go 39.95% <0.00%> (-6.89%) ⬇️
...ingcap/tiup/components/playground/instance/tidb.go 85.36% <0.00%> (-5.34%) ⬇️
...ingcap/tiup/components/playground/instance/tikv.go 75.00% <0.00%> (-4.32%) ⬇️
go/src/github.com/pingcap/tiup/cmd/root.go 60.43% <0.00%> (-3.85%) ⬇️
...pingcap/tiup/components/cluster/command/destroy.go 60.37% <0.00%> (-2.79%) ⬇️
...cap/tiup/components/playground/instance/tiflash.go 61.29% <0.00%> (-2.49%) ⬇️
...om/pingcap/tiup/components/cluster/command/root.go 43.03% <0.00%> (-2.24%) ⬇️
...om/pingcap/tiup/components/cluster/command/test.go 62.22% <0.00%> (-2.07%) ⬇️
... and 120 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f73cb5f...639efff. Read the comment docs.

@lucklove lucklove requested a review from july2993 July 6, 2020 03:41
@ti-srebot
Copy link
Contributor

@july2993,Thanks for your review.

Copy link
Contributor

@ti-srebot ti-srebot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lucklove and others added 2 commits July 6, 2020 12:18
Signed-off-by: lucklove <gnu.crazier@gmail.com>
@ti-srebot
Copy link
Contributor

@lonng,Thanks for your review.

lonng and others added 3 commits July 6, 2020 14:55
Signed-off-by: lucklove <gnu.crazier@gmail.com>
Signed-off-by: lucklove <gnu.crazier@gmail.com>
@lucklove lucklove merged commit de29ee7 into pingcap:master Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug-fix Categorizes PR as a bug-fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tiup cluster patch can't overwrite twice
6 participants