-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support deploy and manage dm 2.0 #587
Conversation
729ae4d
to
a299cc1
Compare
Codecov Report
@@ Coverage Diff @@
## master #587 +/- ##
==========================================
- Coverage 47.79% 47.40% -0.39%
==========================================
Files 224 227 +3
Lines 16818 17121 +303
==========================================
+ Hits 8038 8117 +79
- Misses 7653 7892 +239
+ Partials 1127 1112 -15
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@lonng @AstroProfundis PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome works.
Rest LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@lonng @AstroProfundis PTAL |
ref #557
close #461
This PR refactor some code and make tiup-dm support all commands like tiup-cluster(except for
check
andimport
)components/cluster/command/*
are move intopkg/cluster/deploy/
and change it to deploy a general cluster instead of tidb cluster, both tiup-cluster and tiup-dm use it to avoid many duplicate codes, and maybe later for some tiup-** to use it too.pkg/dm/
intocomponents/dm
tiup-cluser
specified code into component/cluster later.all the existing command are supported:
a cluster may look like:
tests: