Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the bug that ctl working directory is different with TiUP #589

Merged
merged 2 commits into from
Jul 9, 2020

Conversation

lonng
Copy link
Contributor

@lonng lonng commented Jul 8, 2020

Signed-off-by: Lonng heng@lonng.org

What problem does this PR solve?

Fix #584

@lonng lonng added the type/bug-fix Categorizes PR as a bug-fix label Jul 8, 2020
@lonng lonng requested a review from lucklove July 8, 2020 12:56
@codecov-commenter
Copy link

codecov-commenter commented Jul 8, 2020

Codecov Report

Merging #589 into master will increase coverage by 10.72%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #589       +/-   ##
===========================================
+ Coverage   39.84%   50.56%   +10.72%     
===========================================
  Files         201      219       +18     
  Lines       14847    15897     +1050     
===========================================
+ Hits         5916     8039     +2123     
+ Misses       8072     6738     -1334     
- Partials      859     1120      +261     
Flag Coverage Δ
#coverage 50.56% <ø> (+10.72%) ⬆️
Impacted Files Coverage Δ
...o/src/github.com/pingcap/tiup/server/store/sync.go 28.57% <0.00%> (-28.58%) ⬇️
....com/pingcap/tiup/pkg/cluster/clusterutil/retry.go 50.00% <0.00%> (-17.50%) ⬇️
go/src/github.com/pingcap/tiup/cmd/mirror.go 39.95% <0.00%> (-6.89%) ⬇️
...ingcap/tiup/components/playground/instance/tidb.go 85.36% <0.00%> (-5.34%) ⬇️
...ingcap/tiup/components/playground/instance/tikv.go 75.00% <0.00%> (-4.32%) ⬇️
go/src/github.com/pingcap/tiup/cmd/root.go 60.43% <0.00%> (-3.85%) ⬇️
...pingcap/tiup/components/cluster/command/destroy.go 60.37% <0.00%> (-2.79%) ⬇️
...cap/tiup/components/playground/instance/tiflash.go 61.29% <0.00%> (-2.49%) ⬇️
...om/pingcap/tiup/components/cluster/command/test.go 62.22% <0.00%> (-2.07%) ⬇️
...om/pingcap/tiup/components/cluster/command/root.go 43.39% <0.00%> (-1.88%) ⬇️
... and 123 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02e306d...e61865f. Read the comment docs.

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 9, 2020
@ti-srebot
Copy link
Contributor

@july2993,Thanks for your review.

Copy link
Member

@lucklove lucklove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 9, 2020
@ti-srebot
Copy link
Contributor

@lucklove,Thanks for your review.

@lucklove
Copy link
Member

lucklove commented Jul 9, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 9, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit d9ad659 into master Jul 9, 2020
@ti-srebot ti-srebot deleted the fix-ctl branch July 9, 2020 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bug-fix Categorizes PR as a bug-fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tiup ctl cdc changefeed create failed
5 participants