Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: show msw bug #679

Closed
wants to merge 3 commits into from
Closed

chore: show msw bug #679

wants to merge 3 commits into from

Conversation

juliusmarminge
Copy link
Collaborator

@juliusmarminge juliusmarminge commented Mar 7, 2024

msw doesn't intercept this call, if it did we would've got the mocked response instead of the Invalid API Key error which is coming from the UploadThing API

CleanShot 2024-03-07 at 14 14 05

CleanShot 2024-03-07 at 14 08 19


to test:

In root: bun i

In root: bun vitest sdk

Copy link

changeset-bot bot commented Mar 7, 2024

⚠️ No Changeset found

Latest commit: c6c381b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Mar 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs-uploadthing ⬜️ Ignored (Inspect) Visit Preview Mar 7, 2024 1:16pm

@juliusmarminge juliusmarminge added the ❌❗ DO NOT MERGE DO NOT MERGE label Mar 7, 2024
@juliusmarminge juliusmarminge changed the base branch from main to client-tests March 7, 2024 13:09
@juliusmarminge
Copy link
Collaborator Author

juliusmarminge commented Mar 7, 2024

Oh right and this is the other issue, it's not compatible with HappyDOM, that's why I had to do the patch and make it not mock fetch requests in the first place.. (Ref: mswjs/msw#2071 (comment))

CleanShot 2024-03-07 at 14 11 21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant