-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tap to v15 #83
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm once CI is green
Codecov Report
@@ Coverage Diff @@
## master #83 +/- ##
===========================================
+ Coverage 98.00% 100.00% +2.00%
===========================================
Files 2 2
Lines 50 50
===========================================
+ Hits 49 50 +1
+ Misses 1 0 -1
Continue to review full report at Codecov.
|
https://github.com/pinojs/pino-debug/runs/4850023188?check_suite_focus=true#step:6:95 is at least one test that needs to be revised. |
can you fix CI? It seems it does not work anymore with debug@4 |
Updated project to tap 15. Most of changes are due to deprecations:
t.is
,t.throw
)--esm
option was removed. Using causes the failures seen in Bump tap from 14.11.0 to 15.1.5 #73afterEach
no longer supports callbacksNotes
--coverage=true
currently causes some tests to fail.Seems to be related to tapjs/tapjs#669, but I am still investigating. When coverage is enabled, tests that useexecSync
to verify the log redirection to pino fail because it doesn't happen (debug logs are redirected to stderr instead)Edit 2
The problem seems to come from the
nyc
upgrade from v14 to v15: