Use the new Elasticsearch client #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failing on Node 12: https://travis-ci.org/pinojs/pino-elasticsearch/jobs/541274020 |
|
I saw that, but the test is passing on my machine. I fear is a timing issue. |
|
Now CI is green. Unfortunately, Travis may cause this flaky tests from time to time. |
mcollina
reviewed
Jun 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As titled.
This pr also removes the aws configuration, since the package has not been updated to support the new client.
It introduces two new cli options:
node: the URL where Elasticsearch is runninges-version: the major version of Elasticsearch you are using (needed only if ≤7)It removes
host,port,aws-credentials.The minimum version of Node.js required is v8.