fix(levels): useLevelLabels permanently mutates initial cache (#684)

* fix(levels): useLevelLabels permanently mutates initial cache * simplify implimentation - always copy the instance state when recreating
pinojs · Jul 23, 2019 · 10a5d1c · 10a5d1c
1 parent 560d8bd
commit 10a5d1c
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/lib/levels.js b/lib/levels.js
@@ -38,7 +38,7 @@ function genLsCache (instance) {
       ? `{"${levelName}":"${instance.levels.labels[k]}"`
       : flatstr(`{"${levelName}":` + Number(k))
     return o
-  }, instance[lsCacheSym])
+  }, Object.assign({}, instance[lsCacheSym]))
   return instance
 }
 

diff --git a/test/levels.test.js b/test/levels.test.js
@@ -242,6 +242,21 @@ test('produces labels when told to', async ({ is }) => {
   instance.info('hello world')
 })
 
+test('resets levels from labels to numbers', async ({ is }) => {
+  const expected = [{
+    level: 30,
+    msg: 'hello world'
+  }]
+  pino({ useLevelLabels: true })
+  const instance = pino({ useLevelLabels: false }, sink((result, enc, cb) => {
+    const current = expected.shift()
+    check(is, result, current.level, current.msg)
+    cb()
+  }))
+
+  instance.info('hello world')
+})
+
 test('changes label naming when told to', async ({ is }) => {
   const expected = [{
     priority: 30,