Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add crlf in LoggerOptions Interface #1696

Merged

Conversation

tarunrajput
Copy link
Contributor

Added missing crlf option in LoggerOptions Interface
Related: #1679

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina
Copy link
Member

mcollina commented May 3, 2023

Could you rebase? CI should be passing now

@tarunrajput tarunrajput force-pushed the add-clrf-to-LoggerOptions-interface branch from c85b3e2 to 03c12bd Compare May 3, 2023 10:07
@tarunrajput
Copy link
Contributor Author

Could you rebase? CI should be passing now

@mcollina , done

@mcollina mcollina merged commit 4a819bf into pinojs:master May 3, 2023
Copy link

github-actions bot commented May 4, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants