instance.child() should set the level property in pino #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -230,6 +230,8 @@ the current log level of the parent at the time they are spawned. | |||
|
|
|||
| From v2.x.x the log level of a child is mutable (whereas in | |||
| v1.x.x it was immutable), and can be set independently of the parent. | |||
| You can pass `level` as a property inside the `bindings`, and that will | |||
There was a problem hiding this comment.
If a level property is present in the object passed to child it will override the child logger level.
|
good to go man |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #55.
@davidmarkclements please review.
Benchmarks stays the same.