more careful timestamp retrieval #675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsumners
requested changes
Jul 4, 2019
lib/proto.js
Outdated
| @@ -130,7 +130,8 @@ function write (_obj, msg, num) { | |||
| // it is not needed anymore | |||
| stream.lastMsg = msg | |||
| stream.lastObj = obj | |||
| stream.lastTime = t.slice(8) | |||
| const timeMatch = t.match(/\d+/) | |||
There was a problem hiding this comment.
We shouldn’t have a regular expression in this hot path. It would be better to use .slice with a correct count.
There was a problem hiding this comment.
Added timeSliceIndexSym with correct count.
test/pretty.test.js
Outdated
| @@ -178,7 +178,7 @@ test('with custom timestamp', async ({ is }) => { | |||
| cb() | |||
There was a problem hiding this comment.
I’m not sure about overloading this test to test two things. I think there should be separate tests to cover both items.
ilya-mim
force-pushed
the
fix-pino-metadata-lasttime
branch
from
46555e5
to
e4959cc
Compare
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #669
It allows to retrieval lastTime value more careful when custom time label is used.