fix(redaction): fix corner cases with paths #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In particular, this supports single-item paths where the first item is
bracketed (e.g. `{ redact: ["['some-key']"] }`) and paths where one of
the segments is the empty string [in brackets] (e.g., `{ redact:
["a[''].x"] }`).
Conceptually, the change is quite simple: it uses the namespace rather,
than the string, even for single-segment paths, since the namespace has
the brackets + quotes removed. It also changes the namespace `.replace`
regex to allow 0 character (i.e., `.*` instead of `.+`) between the
quotes.
|
@mcollina Next steps to getting this merged/published? I'd love to delete my fork :) |
|
@davidmarkclements can you take a look? |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular, this supports single-item paths where the first item is bracketed (e.g.
{ redact: ["['some-key']"] }) and paths where one of the segments is the empty string [in brackets] (e.g.,{ redact: ["a[''].x"] }).Conceptually, the change is quite simple: it uses the namespace rather, than the string, even for single-segment paths, since the namespace has the brackets + quotes removed. It also changes the namespace
.replaceregex to allow 0 character (i.e.,.*instead of.+) between the quotes.