-
Notifications
You must be signed in to change notification settings - Fork 876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mixin): add mixin config option #741
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind to validate that it is a function?
Wouldn't this function need to be synchronous? That should be called out in the docs. I'm not enamored with the name "mixin" but I don't have a better suggestion either. |
Fixed 👍
Yes, it should be synchronous. My intent was that this was obvious from the docs, as it says that the function "must return an object" and that "the properties of the returned object will be added to the logged JSON". So while I didn't use the word synchronous directly, I thought that the usage could easily be derived. But if you like me to specifically state that it should be called synchronous, I'll do that 👍 |
I think it is better to be explicit because people do weird things. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@jsumners I've updated the docs 👍 |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
@mcollina here's the "context" PR as we talked about at NodeConf. I ended up calling the feature "mixin" instead, as I think that suits the use-case better. But feel free to suggest other names 😃