Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the changeLevelName option and alias it to levelKey #772

Merged
merged 3 commits into from
Feb 28, 2020

Conversation

ornotandrew
Copy link
Contributor

There was some discussion in pino-pretty about this.

I'm not sure what sort of approach is normally used when deprecating something, but I thought I'd open a PR just to get the ball rolling.

docs/api.md Outdated Show resolved Hide resolved
lib/tools.js Show resolved Hide resolved
test/levels.test.js Outdated Show resolved Hide resolved
@davidmarkclements
Copy link
Member

@jsumners deprecation warnings from other modules won't use the logger, however instead of console.warn it should be process.emitWarning

As an off-thread aside, maybe a module (or even a pino option) for wrapping emitWarning into logger.warn would be good.

@ornotandrew
Copy link
Contributor Author

So in version 7, this aliasing code will need to be removed. Do you guys have a way of tracking that in Github? Should I leave a TODO in the code?

@jsumners
Copy link
Member

I created a project -- https://github.com/pinojs/pino/projects/2

Copy link
Member

@jsumners jsumners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions
Copy link

github-actions bot commented Feb 3, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants