Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add coverage and dependabot ci workflows; tidy docs #961

Merged
merged 7 commits into from
Feb 9, 2021
Merged

chore: add coverage and dependabot ci workflows; tidy docs #961

merged 7 commits into from
Feb 9, 2021

Conversation

Fdawgs
Copy link
Member

@Fdawgs Fdawgs commented Feb 9, 2021

No description provided.

@Fdawgs
Copy link
Member Author

Fdawgs commented Feb 9, 2021

Can't for the life of me figure out why the tap tests are failing when I haven't altered any actual code. 😢

@jsumners
Copy link
Member

jsumners commented Feb 9, 2021

@Fdawgs why have the images changed?

@mcollina could your recent sonic-boom update be causing these test failures?

@Fdawgs
Copy link
Member Author

Fdawgs commented Feb 9, 2021

@Fdawgs why have the images changed?

Hi @jsumners that was imgbot on my fork compressing the png files, can remove if wanted.

@mcollina
Copy link
Member

mcollina commented Feb 9, 2021

Please restore the images. We might want to move them to a graphics repo instead.

@mcollina
Copy link
Member

mcollina commented Feb 9, 2021

@mcollina could your recent sonic-boom update be causing these test failures?

Likely so.

@Fdawgs
Copy link
Member Author

Fdawgs commented Feb 9, 2021

Please restore the images. We might want to move them to a graphics repo instead.

Done, removed the image change commit.

@mcollina
Copy link
Member

mcollina commented Feb 9, 2021

please rebase :)

@Fdawgs
Copy link
Member Author

Fdawgs commented Feb 9, 2021

Rebased!

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jsumners jsumners merged commit 2f20c1b into pinojs:master Feb 9, 2021
@Fdawgs Fdawgs deleted the chore/ci-docs-tidy branch February 10, 2021 06:22
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants