Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EINVAL #190

Merged
merged 1 commit into from
Oct 15, 2024
Merged

EINVAL #190

merged 1 commit into from
Oct 15, 2024

Conversation

ronag
Copy link
Contributor

@ronag ronag commented Dec 29, 2023

Refs: #189

@ronag
Copy link
Contributor Author

ronag commented Dec 29, 2023

no editorconfig or prettier? 😢

mcollina
mcollina approved these changes Dec 30, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina
Copy link
Member

Can you add a test? There are few examples that use proxyquire to mock fs.

@mcollina mcollina merged commit 15f1c32 into pinojs:master Oct 15, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ronag @mcollina