Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web throws NPE when filtering calls with RPC internal types #488

Closed
Xylus opened this issue May 28, 2015 · 0 comments · Fixed by #491
Closed

Web throws NPE when filtering calls with RPC internal types #488

Xylus opened this issue May 28, 2015 · 0 comments · Fixed by #491
Assignees
Labels
Milestone

Comments

@Xylus
Copy link
Contributor

Xylus commented May 28, 2015

When filtering RPC calls on Pinpoint web, NullPointerException is thrown.

This is due to a missing check inside the filtering logic. WAS -> WAS filtering checks each span event for its ServiceType and if it is in the RPC range (9000~9999), does an equals check with the span event's destinationId. Since RPC internal methods does not have a destinationId, while being within the RPC range, NPE is thrown.

Fix needs 2 checks - to check if the span event's ServiceType is set to record statistics, and to check for null destinationId.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant