ModalAlert: Add documentation and best practices #2450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for gestalt ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
ayeshakmaz
commented
Oct 21, 2022
| @@ -1390,6 +1390,56 @@ const GENERAL_COMPONENT_LIST: $ReadOnlyArray<ListItemType> = [ | |||
| figma: null, | |||
| }, | |||
| }, | |||
| { | |||
| svg: <Modal />, | |||
There was a problem hiding this comment.
Using the same svg for now, but will update once I make a new illustration
docs/pages/web/modalalert.js
Outdated
| description="Use language that makes it hard to understand what action is being taken, while adding additional actions that may take the user out of their existing context." | ||
| cardSize="lg" | ||
| type="do" | ||
| description="Use to overlay Page content. ModalAlerts should be horizontally and vertically centered on the screen." |
There was a problem hiding this comment.
Is this one required? I dont think this is specific for ModalAlert but for all Modals?
There was a problem hiding this comment.
Good call, removed
AlbertCarreras
approved these changes
Oct 21, 2022
| primaryAction={{ | ||
| accessibilityLabel: 'Update credit card info', | ||
| label: 'Update credit card', | ||
| href: 'https://www.pinterest.com', |
There was a problem hiding this comment.
Are we adding the visit icon to all primary actions with URLs? What;s the intention of the icon?
There was a problem hiding this comment.
The icon showcases that folks are going to be navigated away from the modal to a new page instead of just closing the modal like non-link buttons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
What changed?
Add documentation and examples for ModalAlert
Why?
Add Best Practice and Variant sandpack examples.
Also updates the padding on Modal and ModalAlert footers
Links
Checklist