Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider honoring PrivatePropertyName like PropertyName #2612

Closed
Goooler opened this issue Mar 14, 2024 · 1 comment · Fixed by #2643
Closed

Consider honoring PrivatePropertyName like PropertyName #2612

Goooler opened this issue Mar 14, 2024 · 1 comment · Fixed by #2643
Milestone

Comments

@Goooler
Copy link
Contributor

Goooler commented Mar 14, 2024

Expected Behavior

PrivatePropertyName is from IntelliJ, we can honor it like PropertyName, links #2441.

image

Current Behavior

Error throwing:

Property name should start with a lowercase letter and use camel case (standard:property-naming)

Additional information

  • Current version of ktlint: 1.2.1
@paul-dingemans
Copy link
Collaborator

We can do so. But according to the inspection settings there even seem to be more inspections/suppression that can be used as a trigger.

We have to create code samples that trigger those warnings to find the id of the suppression. We also need these for the unit tests. Alternatively, we can look them up. For example see https://github.com/JakeWharton/kotlin/blob/4383335168338df9bbbe2a63cb213a68d0858104/idea/src/META-INF/plugin.xml.173#L2546

Screenshot 2024-03-14 at 17 57 17

@paul-dingemans paul-dingemans added this to the 1.3.0 milestone Mar 14, 2024
paul-dingemans added a commit that referenced this issue Apr 23, 2024
When Intellij IDEA suppressions `ObjectPropertyName` or `PrivatePropertyName` are used, then also suppress ktlint `property-naming` rule.

Closes #2612
paul-dingemans added a commit that referenced this issue Apr 23, 2024
When Intellij IDEA suppressions `ObjectPropertyName` or `PrivatePropertyName` are used, then also suppress ktlint `property-naming` rule.

Closes #2612
@paul-dingemans paul-dingemans modified the milestones: 1.4.0, 1.3.0 Apr 23, 2024
paul-dingemans added a commit that referenced this issue Apr 23, 2024
…pertyName` (#2643)

When Intellij IDEA suppressions `ObjectPropertyName` or `PrivatePropertyName` are used, then also suppress ktlint `property-naming` rule.

Closes #2612
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants