Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MavenDependencyResolver #451

Closed
bethcutler opened this issue Jun 4, 2019 · 4 comments · Fixed by #566
Closed

Remove MavenDependencyResolver #451

bethcutler opened this issue Jun 4, 2019 · 4 comments · Fixed by #566
Milestone

Comments

@bethcutler
Copy link
Contributor

See discussion in #445.

Basically, the Maven source seems to be a large dependency in ktlint for a small feature that may not be frequently used. I think we should consider removing this dependency.

@shashachu
Copy link
Contributor

Makes total sense to me. Anyone who needs a custom reporter can run it from a local jar.

@Tapchicoma
Copy link
Collaborator

I would propose to do it gracefully - for next release print warning message with a link to this issue, whenever 3rd party rule/reporter dependency is requested

If nobody will provide solid arguments why it should stay - remove it in the release after.

@shashachu
Copy link
Contributor

I would propose to do it gracefully - for next release print warning message with a link to this issue, whenever 3rd party rule/reporter dependency is requested

If nobody will provide solid arguments why it should stay - remove it in the release after.

That's a great idea.

@MaxAller
Copy link

MaxAller commented Oct 3, 2019

When is this going to be released? We're actively waiting on this change :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants