Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent exception in binary-expression-wrapping rule #2607

Merged
merged 1 commit into from
Mar 17, 2024

Conversation

paul-dingemans
Copy link
Collaborator

Description

Prevent exception in binary-expression-wrapping rule in case it is preceded on the same line by a block comment containing a newline character

Function leavesOnLine calls function getFirstLeafOnLineOrSelf which finds the first leaf on the line by looking for newline character. A block comment containing a newline character resulted in considering that block comment to be the first element on the line, even in case it was preceded by other elements on the same line.

Due to this change, the max-line-length rule failed, which has been resolved by refactoring the calculation of the line length.

Closes #2601

Checklist

Before submitting the PR, please check following (checks which are not relevant may be ignored):

  • Commit message are well written. In addition to a short title, the commit message also explain why a change is made.
  • At least one commit message contains a reference Closes #<xxx> or Fixes #<xxx> (replace<xxx> with issue number)
  • Tests are added
  • KtLint format has been applied on source code itself and violations are fixed
  • PR title is short and clear (it is used as description in the release changelog)
  • PR description added (background information)

Documentation is updated. See difference between snapshot and release documentation

  • Snapshot documentation in case documentation is to be released together with a code change
  • Release documentation in case documentation is related to a released version of ktlint and has to be published as soon as the change is merged to master

…preceded on the same line by a block comment containing a newline character

Function `leavesOnLine` calls function `getFirstLeafOnLineOrSelf` which finds the first leaf on the line by looking for newline character. A block comment containing a newline character resulted in considering that block comment to be the first element on the line, even in case it was preceded by other elements on the same line.

Due to this change, the `max-line-length` rule failed, which has been resolved by refactoring the calculation of the line length.

Closes #2601
@paul-dingemans paul-dingemans added this to the 1.2.2 milestone Mar 12, 2024
@paul-dingemans paul-dingemans merged commit a0763b8 into master Mar 17, 2024
12 checks passed
@paul-dingemans paul-dingemans deleted the 2601-binary-expression-wrapping branch March 17, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Internal Error (rule 'standard:binary-expression-wrapping')
1 participant