Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: Add user guide link for table sampling feature #1460

Merged
merged 11 commits into from
Jun 19, 2024
Merged

ui: Add user guide link for table sampling feature #1460

merged 11 commits into from
Jun 19, 2024

Conversation

zhangvi7
Copy link
Contributor

@zhangvi7 zhangvi7 commented Jun 13, 2024 •
edited
Loading

Context

Changes to make more clear to users what happens if they enable table sampling:

  • Add wiki page on Querybook for table sampling user guide
    • Wiki url set in querybook/config/querybook_public_config.yaml
  • Show before and after when sample queries are applied on sampling more information click

Test Plan

image
image

@zhangvi7 zhangvi7 self-assigned this Jun 13, 2024
@zhangvi7 zhangvi7 marked this pull request as ready for review June 13, 2024 02:06
@zhangvi7 zhangvi7 requested a review from czgu June 17, 2024 18:43
@zhangvi7
Copy link
Contributor Author

  • Updated for adhoc view as well
  • Fix issue with sample rate getter

@zhangvi7 zhangvi7 mentioned this pull request Jun 17, 2024
Closed
@zhangvi7 zhangvi7 requested a review from jczhong84 June 18, 2024 15:53
@zhangvi7 zhangvi7 requested a review from jczhong84 June 19, 2024 02:00
@zhangvi7 zhangvi7 merged commit 054774f into pinterest:master Jun 19, 2024
3 checks passed
@zhangvi7 zhangvi7 mentioned this pull request Jun 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czgu czgu czgu approved these changes

@kgopal492 kgopal492 Awaiting requested review from kgopal492

@jczhong84 jczhong84 Awaiting requested review from jczhong84

Assignees

@zhangvi7 zhangvi7

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhangvi7 @czgu @jczhong84