Locale-dependent test

[andrioni]

Hello! This DateMessageParser test is locale-dependent, and fails in non-English locales (which is how I discovered it!).

What would the best solution for this issue? Adding a new locale parameter (e.g. message.timestamp.locale) or just removing the test?

[pgarbacki]

Although it is a bit ugly from the stylistic point of view, you could
change the default locale
http://docs.oracle.com/javase/7/docs/api/java/util/Locale.html#setDefault(java.util.Locale)
for that test, and then change it back.

On Mon, Feb 23, 2015 at 1:44 PM, Alessandro Andrioni <
notifications@github.com> wrote:

Hello! This DateMessageParser test
https://github.com/pinterest/secor/blob/master/src/test/java/com/pinterest/secor/parser/DateMessageParserTest.java#L53-L55
is locale-dependent, and fails in non-English locales (which is how I
discovered it!).

What would the best solution for this issue? Adding a new locale parameter
(e.g. message.timestamp.locale) or just removing the test?

—
Reply to this email directly or view it on GitHub
#78.

[pgarbacki]

@zago would you mind taking a look at this test?