Added options for S3 managed and customer-key based encryption, fixed… #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -41,10 +44,15 @@ | |||
| * default credential provider chain (supports environment variables, | |||
| * system properties, credientials file, and IAM credentials). | |||
| * | |||
| * If set, it will | |||
There was a problem hiding this comment.
I'll have to open another PR I'm afraid. I had to make my fork private to integrate it with our build system and only realised I couldn't continue with this PR afterwards. I've made a new fork but there appears to be no way to link these up. Will close this now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… dependency issues arising from using newer AWS S3 SDK version