Allowing xtol and ftol stopping criteria in OptimisationController #1508
+187
−72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelClerx
force-pushed
the
1502-xtol-ftol
branch
from
5fe02a3
to
6105472
Compare
|
@martinjrobins @chonlei @mirams can you have a look and see if this makes sense, before I add tests? |
mirams
reviewed
Nov 21, 2023
| @@ -5,8 +5,9 @@ All notable changes to this project will be documented in this file. | |||
| ## Unreleased | |||
|
|
|||
| ### Added | |||
| - [#1508](https://github.com/pints-team/pints/pull/1508) Added a method `OptimisationController.set_max_unmoved_iterations` that allows methods to stop after 1 or more iterations with no significant movement in parameter space. | |||
There was a problem hiding this comment.
"unmoved/unchanged" is a bit vague and not immediately obvious to me in terms of whether it refers to xtol or ftol? unmoved parameters, unchanged objective?
There was a problem hiding this comment.
I agree! But can't think of anything better that doesn't involve deprecating set_max_unchanged_iterations which is probably one of the most used methods of the controller class
There was a problem hiding this comment.
Hmmmm, given all the different names that exist already, inventing another set that are pints specific doesn't seem great anyway - and even more so if they are vague!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1502
set_max_unchanged_iterations(1, ftol)set_max_unmoved_iterations(1, xtol)