Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to select certificate based on ClientHello random bytes #583

Merged
merged 1 commit into from
Jun 9, 2024

Conversation

mingyech
Copy link
Member

Description

This PR lets clients to modify the client hello random bytes and lets servers to choose certificates based on the ClientHello random bytes using the GetCertificate function.

This serves a similar purpose to ServerName in the ClientHello, where the server can use different certificate based on the ServerName in the ClientHello. This change would be useful for censorship resistance settings where the client does not want to add extra extension like ServerName in the ClientHello to prevent censors from fingerprinting the connection.

Copy link

codecov bot commented Jun 9, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 80.09%. Comparing base (eddca22) to head (0a2438a).

Files Patch % Lines
state.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #583      +/-   ##
==========================================
+ Coverage   80.07%   80.09%   +0.02%     
==========================================
  Files         101      101              
  Lines        5324     5330       +6     
==========================================
+ Hits         4263     4269       +6     
  Misses        686      686              
  Partials      375      375              
Flag Coverage Δ
go 80.12% <66.66%> (+0.02%) ⬆️
wasm 63.90% <66.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sean-Der Sean-Der merged commit 61b3466 into pion:master Jun 9, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants