Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow user to specify PSK #66

Merged
merged 2 commits into from
May 23, 2019
Merged

Allow user to specify PSK #66

merged 2 commits into from
May 23, 2019

Conversation

Sean-Der
Copy link
Member

Add configuration option for user to pass PSK. When a user
passes a PSK then we only allow CipherSuites that do PSK.

If user passes a PSK and a certificate return an error.

Relates to #45

LanderN
LanderN reviewed May 22, 2019
View reviewed changes
conn.go Show resolved Hide resolved
backkem
backkem reviewed May 22, 2019
View reviewed changes
examples/listen/main.go Outdated Show resolved Hide resolved
LanderN
LanderN reviewed May 22, 2019
View reviewed changes
examples/listen/main.go Outdated Show resolved Hide resolved
igolaizola
igolaizola reviewed May 22, 2019
View reviewed changes
config.go Outdated Show resolved Hide resolved
@Sean-Der Sean-Der requested review from daenney, backkem, LanderN and igolaizola and removed request for LanderN May 23, 2019 05:13
@codecov-io
Copy link

codecov-io commented May 23, 2019 •
edited
Loading

Codecov Report

Merging #66 into master will increase coverage by 0.3%.
The diff coverage is 85.13%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master     #66     +/-   ##
========================================
+ Coverage    70.8%   71.1%   +0.3%     
========================================
  Files          48      48             
  Lines        2596    2627     +31     
========================================
+ Hits         1838    1868     +30     
- Misses        549     552      +3     
+ Partials      209     207      -2
Impacted Files Coverage Δ
...pher_suite_tls_ecdhe_ecdsa_with_aes_256_cbc_sha.go 84.21% <100%> (+0.87%) ⬆️
cipher_suite.go 100% <100%> (ø) ⬆️
...r_suite_tls_ecdhe_ecdsa_with_aes_128_gcm_sha256.go 81.25% <100%> (+1.25%) ⬆️
conn.go 76.04% <73.17%> (-0.52%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0ae333...8969731. Read the comment docs.

@Sean-Der
Allow user to specify PSK
24cc2f1 
Add configuration option for user to pass PSK. When a user
passes a PSK then we only allow CipherSuites that do PSK.

If user passes a PSK and a certificate return an error.

Relates to #45
@Sean-Der
Update PSK Config to pass PSK Identity hint
8969731 
Also simplify CipherSuite filtering relating to
PSK/non-PSK suites

Relates to #45
@Sean-Der Sean-Der merged commit bb439be into master May 23, 2019
@Sean-Der Sean-Der deleted the issue-45 branch May 24, 2019 23:03
@daenney daenney mentioned this pull request Jul 4, 2019
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LanderN LanderN LanderN approved these changes

@igolaizola igolaizola igolaizola approved these changes

@daenney daenney Awaiting requested review from daenney

@backkem backkem Awaiting requested review from backkem

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Sean-Der @codecov-io @daenney @igolaizola @LanderN @backkem