Implement restartIce functionality?

[jjmaldonis]

Summary

Are you planning to support the ICERestart feature? It's available as an option in the OfferOptions struct, but options are not allowed as a parameter to PeerConnection.CreateOffer.

Motivation

Currently the only way to reconnect to a WebRTC session is to tear down the peer connection and recreate it on both sides. There's quite a bit of communication overhead required to do that, which is normally taken care of by the ICERestart flag.

Google's WebRTC implementation implements the ICE restart functionality.

I don't know if this is on your radar right now or not.

Describe alternatives you've considered

Repeated from above: "Currently the only way to reconnect to a WebRTC session is to tear down the peer connection and recreate it on both sides. There's quite a bit of communication overhead required to do that, which is normally taken care of by the ICERestart flag."

Additional Context

N/A

[Sean-Der]

Hey @jjmaldonis thanks for checking out Pion!

Yes I would like to support it. I also don't believe it would be that much development work either.

We will need to evaluate if it is easier to restart an ICEAgent (or create a whole new one). I am leaning toward restarting it, so others can benefit from the change.

My goal is have 100% coverage of the webrtc-pc RFC! If you are interested/have time I would love to support you getting ICERestarts in. If not I think this can probably happen before the end of the year. I have already obligated myself to a few other big features :)

[jjmaldonis]

Thanks that's great. I'm not sure if I can commit to implementing the iceRestart flag right now. If that changes, I'll let you know. I'm really looking forward to it though, and thanks for the awesome library and all your hard work!

[normanr]

What's the expect action to take if a DataChannel.Send() fails due to connection failure? (sending payload data in non-established state: state=Closed). Should that DataChannel 'heal' once the connection state goes back to connected? or should the calling code Close() the channel, and reopen a new one?