Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support IPv6 from mDNS #660

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Support IPv6 from mDNS #660

merged 1 commit into from
Mar 27, 2024

Conversation

edaniels
Copy link
Member

@edaniels edaniels commented Mar 25, 2024

No description provided.

@Sean-Der
Copy link
Member

@edaniels Would it possible to limit this just to mDNS for now?

I would love to see these other things fixed, but as unique efforts/PRs.

The Mux setup in ICE in particular needs evaluated. We have 3 different UDP Mux's I believe, and they all have different issues. Before we break any APIs I would like to understand them all and do one clean break!

@edaniels
Copy link
Member Author

@edaniels Would it possible to limit this just to mDNS for now?

I would love to see these other things fixed, but as unique efforts/PRs.

The Mux setup in ICE in particular needs evaluated. We have 3 different UDP Mux's I believe, and they all have different issues. Before we break any APIs I would like to understand them all and do one clean break!

I want to say yes but let's see what breaks when I undo those changes in this PR. They must have happened in combination with a TCP mux plus mDNS tests. If they don't break, I'll keep it undone. If they do, I'll see if I can create a temporary hidden interface that is an experimental API that works for the mixed implemented in the pkg!

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 74.13333% with 97 lines in your changes are missing coverage. Please review.

Project coverage is 78.75%. Comparing base (ae1ba6f) to head (8af8f9c).

Files Patch % Lines
gather.go 62.16% 21 Missing and 7 partials ⚠️
addr.go 63.01% 20 Missing and 7 partials ⚠️
agent.go 65.78% 7 Missing and 6 partials ⚠️
mdns.go 78.18% 9 Missing and 3 partials ⚠️
candidate_base.go 72.72% 2 Missing and 1 partial ⚠️
candidate_host.go 75.00% 1 Missing and 1 partial ⚠️
candidate_peer_reflexive.go 60.00% 1 Missing and 1 partial ⚠️
candidate_relay.go 85.71% 1 Missing and 1 partial ⚠️
candidate_server_reflexive.go 85.71% 1 Missing and 1 partial ⚠️
net.go 94.73% 1 Missing and 1 partial ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #660      +/-   ##
==========================================
+ Coverage   78.56%   78.75%   +0.19%     
==========================================
  Files          42       42              
  Lines        4487     4698     +211     
==========================================
+ Hits         3525     3700     +175     
- Misses        740      767      +27     
- Partials      222      231       +9     
Flag Coverage Δ
go 78.75% <74.13%> (+0.19%) ⬆️
wasm 22.48% <14.93%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edaniels edaniels force-pushed the ipv6 branch 5 times, most recently from 9c0d579 to 5ef09de Compare March 27, 2024 15:15
@Sean-Der Sean-Der merged commit 39c0392 into pion:master Mar 27, 2024
14 checks passed
@edaniels edaniels deleted the ipv6 branch March 27, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants